This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
Give content editors sweeping permissions to administer content #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think ultimately the roles and permissions will undergo a lot of analysis and review before we land them. Given that, I don't want to hold things up, but I also don't totally agree with this. Usually we have a content admin role that is more along these lines, and a content editor role with more limited permissions. I guess since editor is the only one we have now, it makes sense to fix it up and worry about the rest later? |
|
The only reason I wanted to do this is because we don't have thorough test coverage of the current permissions, so we don't know if the content editors actually have useful permissions. If you don't think this is a good idea, then I think it's fine to leave things as they are in HEAD for now... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like the permissions of the
content_editorrole are a lot more fiddly than they should be. That could lead to inconsistency and weird bugs.I think it makes sense to say that content editors should be fully in charge of content and can do anything to content on the site (nodes, taxonomies, blocks, media), regardless of bundle. Content editors shouldn't necessarily be in charge of site structure, but content? Have at it.
This PR removes the fine-grained permissions from the content editor role and replaces them with the broader "administer" permissions.